Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set REFS to 0 when starting the scan boot image #144

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Set REFS to 0 when starting the scan boot image #144

merged 1 commit into from
Jul 31, 2023

Conversation

k-sareen
Copy link
Contributor

No description provided.

@k-sareen
Copy link
Contributor Author

@qinsoon Not sure why it's failing. It passed once and failed twice, right?

@qinsoon
Copy link
Member

qinsoon commented Jun 29, 2023

@qinsoon Not sure why it's failing. It passed once and failed twice, right?

Yes. I think this PR is ok. REFS and ROOTS seems only used in debug. I don't see why this change would cause a failure. I don't think the test failure is related to this PR.

qinsoon
qinsoon approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit c8120a1 into mmtk:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-sareen @qinsoon